feature/business-account #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
approved these changes
Jun 30, 2025
Contributor
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
LGTM with one small CHANGELOG note
CHANGELOG.md
Outdated
| [PR #14](https://github.com/fivetran/dbt_reddit_ads_source/pull/14) includes the following updates: | ||
|
|
||
| ## Breaking Change | ||
| - The source used in `stg_reddit_ads__account_tmp` was updated from `ACCOUNT` to `BUSINESS_ACCOUNT`. |
Contributor
There was a problem hiding this comment.
Let's clarify here that this is intended to align with the connector schema.
fivetran-avinash
approved these changes
Jul 1, 2025
Contributor
There was a problem hiding this comment.
@fivetran-catfritz Small cosmetic suggestion but looks good after that!
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
ACCOUNTtoBUSINESS_ACCOUNTSubmission Checklist
Changelog