-
Notifications
You must be signed in to change notification settings - Fork 0
Fix bug breaking links in Overview of Devices #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated Grafana dashboard JSON to replace two byName matcher options from "${unique_identifier}" to "Device" in overrides and incremented the dashboard version from 30 to 31. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (2)dashboard-deployments/**⚙️ CodeRabbit configuration file
Files:
**/*⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (3)
✨ Finishing Touches🧪 Generate unit tests
Comment |
This was introduced in PR #19 when removing some renaming transformations, but these columns are still renamed to Device meaning that we should not have changed the matcher.
b7678eb to
77c481f
Compare
|



This was introduced in PR #19 when removing some renaming transformations, but these columns are still renamed to Device meaning that we should not have changed the matcher.
Summary by CodeRabbit
Bug Fixes
Chores