-
Notifications
You must be signed in to change notification settings - Fork 0
KE2 ACI: Update document for ke2 data management #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0186e09 to
287f255
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for mounting an Azure File Share into the Kompira container by introducing a new parameter, updating the ARM template, and extending the documentation with usage and data management instructions.
- Added
kompiraSharePathparameter for specifying the container mount path - Configured ACI deployment to mount the
kompira-shareAzure File Share - Expanded README with local mount steps and detailed data management commands
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ke2/cloud/azureci/aci-parameters.json | Added kompiraSharePath parameter with default value "/mnt" |
| ke2/cloud/azureci/aci-deployment.json | Defined new volume and mount configuration for kompira-share |
| ke2/cloud/azureci/README.md | Documented Azure File Share mount steps and Kompira data usage |
Comments suppressed due to low confidence (2)
ke2/cloud/azureci/README.md:300
- [nitpick] Use the acronym 'ACI' instead of 'CI' when referring to Azure Container Instances to avoid confusion and maintain consistency.
Azure CI はクラウド上でコンテナを実行するため、Azure プラットフォームやローカルマシンとコンテナ間で直接データを共有することは一般的にできません。
ke2/cloud/azureci/README.md:303
- [nitpick] Inconsistent capitalization of 'Kompira' detected; please standardize on a single casing (e.g., 'Kompira') throughout the documentation.
※ マウントのために、Kompira コンテナ内の任意の既存のディレクトリパスを指定することができます。推奨されるパスは `"/mnt", "/tmp", "/usr/src"` です。
287f255 to
e5c0249
Compare
e5c0249 to
c2f1c6a
Compare
|
conflictをresolveします。 |
183f737 to
0a4cd9b
Compare
0a4cd9b to
51dd78d
Compare
d3081e7 to
1e258a5
Compare
|
あと、今回の変更箇所ではないですが、189 行目の以下の説明の「kompira-nginx-conf」は「rabbitmq-conf」の間違いではないでしょうか? |
0dbd304 to
0a3e35e
Compare
0a3e35e to
599ac66
Compare
KE2 ACIでデータ管理のため、Azure ファイル共有
kompira-var/dataを利用します。そのためにdocを更新しました。