Skip to content

Conversation

@fixpoint-hasan
Copy link
Contributor

@fixpoint-hasan fixpoint-hasan commented May 20, 2025

KE2 ACIでデータ管理のため、Azure ファイル共有 kompira-var/dataを利用します。
そのためにdocを更新しました。

@fixpoint-hasan fixpoint-hasan force-pushed the export-import-share branch 12 times, most recently from 0186e09 to 287f255 Compare May 21, 2025 09:34
@fixpoint-hasan fixpoint-hasan changed the title KE2 ACI: Add export/import option KE2 ACI: Udpate ARM template and document for ke2 data management May 21, 2025
@fixpoint-hasan fixpoint-hasan linked an issue May 21, 2025 that may be closed by this pull request
@fixpoint-hasan fixpoint-hasan self-assigned this May 21, 2025
@fixpoint-hasan fixpoint-hasan added the enhancement New feature or request label May 21, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for mounting an Azure File Share into the Kompira container by introducing a new parameter, updating the ARM template, and extending the documentation with usage and data management instructions.

  • Added kompiraSharePath parameter for specifying the container mount path
  • Configured ACI deployment to mount the kompira-share Azure File Share
  • Expanded README with local mount steps and detailed data management commands

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
ke2/cloud/azureci/aci-parameters.json Added kompiraSharePath parameter with default value "/mnt"
ke2/cloud/azureci/aci-deployment.json Defined new volume and mount configuration for kompira-share
ke2/cloud/azureci/README.md Documented Azure File Share mount steps and Kompira data usage
Comments suppressed due to low confidence (2)

ke2/cloud/azureci/README.md:300

  • [nitpick] Use the acronym 'ACI' instead of 'CI' when referring to Azure Container Instances to avoid confusion and maintain consistency.
Azure CI はクラウド上でコンテナを実行するため、Azure プラットフォームやローカルマシンとコンテナ間で直接データを共有することは一般的にできません。

ke2/cloud/azureci/README.md:303

  • [nitpick] Inconsistent capitalization of 'Kompira' detected; please standardize on a single casing (e.g., 'Kompira') throughout the documentation.
※ マウントのために、Kompira コンテナ内の任意の既存のディレクトリパスを指定することができます。推奨されるパスは `"/mnt", "/tmp", "/usr/src"` です。

@fixpoint-hasan
Copy link
Contributor Author

conflictをresolveします。

@fixpoint-hasan fixpoint-hasan force-pushed the export-import-share branch 2 times, most recently from 183f737 to 0a4cd9b Compare May 29, 2025 05:22
@fixpoint-hasan fixpoint-hasan changed the title KE2 ACI: Udpate ARM template and document for ke2 data management KE2 ACI: Update document for ke2 data management May 29, 2025
@tichi73
Copy link
Contributor

tichi73 commented Jun 5, 2025

あと、今回の変更箇所ではないですが、189 行目の以下の説明の「kompira-nginx-conf」は「rabbitmq-conf」の間違いではないでしょうか?

Azure ポータルにログインして、ke20storage ストレージアカウントのファイル共有 kompira-nginx-conf に移動し、
画面上からアップロードすることも可能です。

@fixpoint-hasan fixpoint-hasan requested a review from tichi73 June 5, 2025 23:29
@fixpoint-hasan fixpoint-hasan merged commit 2e63bbb into develop Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

データ管理のためdocを更新する

4 participants