Skip to content

feat: More Lights! [flame_3d]#3250

Merged
luanpotter merged 7 commits intoflame_3dfrom
luan.modern-lights
Aug 15, 2024
Merged

feat: More Lights! [flame_3d]#3250
luanpotter merged 7 commits intoflame_3dfrom
luan.modern-lights

Conversation

@luanpotter
Copy link
Copy Markdown
Member

@luanpotter luanpotter commented Jul 29, 2024 •
edited
Loading

Description

More Lights! More fun!

I am still trying to get arrays to work (not even the fancy SSBOs, just plain fixed arrays).

In the meanwhile this puts lights as separate objects.

This supports:

  • point lights
  • ambient lights
  • colors
  • intensity

image

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter force-pushed the luan.modern-lights branch 2 times, most recently from fc214a9 to 83cbafc Compare July 29, 2024 12:27
luanpotter
luanpotter commented Jul 29, 2024
View reviewed changes
Comment thread packages/flame_3d/lib/src/camera/world_3d.dart
@luanpotter luanpotter force-pushed the luan.modern-lights branch 2 times, most recently from 5198e9c to 10ba5c4 Compare July 29, 2024 13:18
@luanpotter luanpotter marked this pull request as ready for review July 29, 2024 13:28
@luanpotter luanpotter requested review from spydon and wolfenrain July 29, 2024 14:19
erickzanardo
erickzanardo approved these changes Aug 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly some style nits, I wonder if our lint isn't configured?

I don't know much about 3D stuff, so I would advise additional review

Comment thread packages/flame_3d/lib/src/graphics/graphics_device.dart
Comment thread packages/flame_3d/lib/src/resources/light/lighting_info.dart Outdated
Comment thread packages/flame_3d/lib/src/resources/light/lighting_info.dart Outdated
Comment thread packages/flame_3d/lib/src/resources/light/lighting_info.dart Outdated
Comment thread packages/flame_3d/lib/src/resources/light/lighting_info.dart
@luanpotter
Copy link
Copy Markdown
Member Author

luanpotter commented Aug 9, 2024

I wonder if our lint isn't configured?

That is a good q, let me make sure it is working as intended, at least locally. Maybe I just forgot to run it but pretty sure I did. This is very important to have setup.

@luanpotter
Copy link
Copy Markdown
Member Author

luanpotter commented Aug 9, 2024

@erickzanardo yep I did run it locally:
image
I will try to figure out what's wrong, good catch

@luanpotter luanpotter force-pushed the luan.modern-lights branch 2 times, most recently from 6150269 to 6a6fb51 Compare August 9, 2024 18:39
@luanpotter luanpotter force-pushed the luan.modern-lights branch 3 times, most recently from b55ba58 to 324f1b0 Compare August 14, 2024 01:18
wolfenrain
wolfenrain reviewed Aug 15, 2024
View reviewed changes
Comment thread packages/flame_3d/lib/src/resources/shader/shader.dart Outdated
wolfenrain
wolfenrain reviewed Aug 15, 2024
View reviewed changes
Comment thread packages/flame_3d/shaders/spatial_material.frag Outdated
luanpotter
luanpotter commented Aug 15, 2024
View reviewed changes
Comment thread packages/flame_3d/lib/src/camera/world_3d.dart
luanpotter
luanpotter commented Aug 15, 2024
View reviewed changes
Comment thread packages/flame_3d/shaders/spatial_material.frag Outdated
luanpotter
luanpotter commented Aug 15, 2024
View reviewed changes
Comment thread packages/flame_3d/shaders/spatial_material.frag Outdated
@luanpotter @wolfenrain
Apply suggestions from code review
d0f58fc 
Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
luanpotter
luanpotter commented Aug 15, 2024
View reviewed changes
Comment thread packages/flame_3d/lib/src/resources/light/lighting_info.dart Outdated
@luanpotter luanpotter merged commit 9694579 into flame_3d Aug 15, 2024
@luanpotter luanpotter deleted the luan.modern-lights branch August 15, 2024 15:40
luanpotter added a commit that referenced this pull request Aug 25, 2024
@luanpotter @wolfenrain
feat: More Lights! [flame_3d] (#3250)
07594dd 
More Lights! More fun!

I am still trying to get arrays to work (not even the fancy SSBOs, just
plain fixed arrays).

In the meanwhile this puts lights as separate objects.

This supports:

* point lights
* ambient lights
* colors
* intensity


![image](https://github.com/user-attachments/assets/a2f75a8a-9c64-42d1-bbe5-bdf58fa7df69)

---------

Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
luanpotter added a commit that referenced this pull request Sep 11, 2024
@luanpotter @wolfenrain
feat: More Lights! [flame_3d] (#3250)
1780630 
More Lights! More fun!

I am still trying to get arrays to work (not even the fancy SSBOs, just
plain fixed arrays).

In the meanwhile this puts lights as separate objects.

This supports:

* point lights
* ambient lights
* colors
* intensity


![image](https://github.com/user-attachments/assets/a2f75a8a-9c64-42d1-bbe5-bdf58fa7df69)

---------

Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
luanpotter added a commit that referenced this pull request Oct 15, 2024
@luanpotter @wolfenrain
feat: More Lights! [flame_3d] (#3250)
6fbc054 
More Lights! More fun!

I am still trying to get arrays to work (not even the fancy SSBOs, just
plain fixed arrays).

In the meanwhile this puts lights as separate objects.

This supports:

* point lights
* ambient lights
* colors
* intensity


![image](https://github.com/user-attachments/assets/a2f75a8a-9c64-42d1-bbe5-bdf58fa7df69)

---------

Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
luanpotter added a commit that referenced this pull request Dec 11, 2024
@luanpotter @wolfenrain
feat: More Lights! [flame_3d] (#3250)
8c3a14c 
More Lights! More fun!

I am still trying to get arrays to work (not even the fancy SSBOs, just
plain fixed arrays).

In the meanwhile this puts lights as separate objects.

This supports:

* point lights
* ambient lights
* colors
* intensity


![image](https://github.com/user-attachments/assets/a2f75a8a-9c64-42d1-bbe5-bdf58fa7df69)

---------

Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
luanpotter added a commit that referenced this pull request Dec 11, 2024
@luanpotter @wolfenrain
feat: More Lights! [flame_3d] (#3250)
5c508e8 
More Lights! More fun!

I am still trying to get arrays to work (not even the fancy SSBOs, just
plain fixed arrays).

In the meanwhile this puts lights as separate objects.

This supports:

* point lights
* ambient lights
* colors
* intensity


![image](https://github.com/user-attachments/assets/a2f75a8a-9c64-42d1-bbe5-bdf58fa7df69)

---------

Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
nickf2k pushed a commit to nickf2k/flame that referenced this pull request Nov 16, 2025
@luanpotter @wolfenrain @vuong3-nguyen
feat: More Lights! [flame_3d] (flame-engine#3250)
c4533f1 
More Lights! More fun!

I am still trying to get arrays to work (not even the fancy SSBOs, just
plain fixed arrays).

In the meanwhile this puts lights as separate objects.

This supports:

* point lights
* ambient lights
* colors
* intensity


![image](https://github.com/user-attachments/assets/a2f75a8a-9c64-42d1-bbe5-bdf58fa7df69)

---------

Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

@spydon spydon Awaiting requested review from spydon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luanpotter @spydon @erickzanardo @wolfenrain