Skip to content

Conversation

@luanpotter
Copy link
Member

@luanpotter luanpotter commented Aug 22, 2024

Description

MeshComponent.bind should bind to the provided device, not the world's.
Note: they are the same device. But semantics are important.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter
Copy link
Member Author

@spydon not sure why the completely unrelated tiled test is consistently failing with ERROR: ERROR: ERROR:

/home/runner/work/flame/flame/packages/flame_tiled/test/tile_atlas_test.dart: TiledAtlas loadImages packs complex maps with multiple images
ERROR: ERROR: ERROR: unhandled error during finalization of test:
/home/runner/work/flame/flame/packages/flame_tiled/test/tile_atlas_test.dart
TestDeviceException(Shell subprocess crashed with segmentation fault.)
#0      FlutterTesterTestDevice.finished (package:flutter_tools/src/test/flutter_tester_device.dart:247:5)
<asynchronous suspension>
#1      FlutterTesterTestDevice.kill (package:flutter_tools/src/test/flutter_tester_device.dart:229:5)
<asynchronous suspension>
#2      FlutterPlatform._startTest.<anonymous closure> (package:flutter_tools/src/test/flutter_platform.dart:535:9)
<asynchronous suspension>
#3      FlutterPlatform._startTest (package:flutter_tools/src/test/flutter_platform.dart:591:11)
<asynchronous suspension>

I suspect it must be something wrong with the newer flutter version we use on this branch!

@luanpotter luanpotter marked this pull request as ready for review August 25, 2024 22:58
@luanpotter luanpotter merged commit e074b49 into flame_3d Aug 25, 2024
@luanpotter luanpotter deleted the luan.fix-device branch August 25, 2024 22:58
luanpotter added a commit that referenced this pull request Sep 11, 2024
MeshComponent.bind should bind to the provided device, not the world's.
Note: they are the same device. But semantics are important.
luanpotter added a commit that referenced this pull request Oct 15, 2024
MeshComponent.bind should bind to the provided device, not the world's.
Note: they are the same device. But semantics are important.
luanpotter added a commit that referenced this pull request Dec 11, 2024
MeshComponent.bind should bind to the provided device, not the world's.
Note: they are the same device. But semantics are important.
luanpotter added a commit that referenced this pull request Dec 11, 2024
MeshComponent.bind should bind to the provided device, not the world's.
Note: they are the same device. But semantics are important.
nickf2k pushed a commit to nickf2k/flame that referenced this pull request Nov 16, 2025
…ine#3278)

MeshComponent.bind should bind to the provided device, not the world's.
Note: they are the same device. But semantics are important.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants