fix: Don't use a future when assets for SpriteButton is already loaded #3456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Benchmark ResultsPackage flame:
Benchmarks provided with 💙 by Dart Benchmark Action. |
erickzanardo
approved these changes
Jan 26, 2025
nickf2k
pushed a commit
to nickf2k/flame
that referenced
this pull request
Nov 16, 2025
flame-engine#3456) When both images are already loaded and we're using a future it will go into loading for one tick, with this PR we avoid that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When both images are already loaded and we're using a future it will go into loading for one tick, with this PR we avoid that.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues