test: Increase transform2D op count in flaky test#3709
Merged
spydon merged 3 commits intoflame-engine:mainfrom Aug 28, 2025
Merged
test: Increase transform2D op count in flaky test#3709spydon merged 3 commits intoflame-engine:mainfrom
spydon merged 3 commits intoflame-engine:mainfrom
Conversation
spydon
changed the title
Contributor
Author
No probs at all, I'm fine with the "You break it, you buy it" policy ;) |
Member
|
@zeyus can you rebase this branch on main? For some reason it doesn't work to do that from the GitHub UI today... |
Contributor
Author
Oh, it worked just now, maybe I forgot to check the "maintainers can commit" or whatever checkbox...I can't see it anywhere on mobile at the moment though. |
nickf2k
pushed a commit
to nickf2k/flame
that referenced
this pull request
Nov 16, 2025
In the initial implementation of the `transform2dRoundTripUncertainty` I tried to approximately figure out how many ops happen in the round trip transform, but it was just an educated guess. Just bumping it by 1 makes the test pass with the given seed `2021996283`, This also adds a helper to run tests with a specific random seed without modifying the tests, e.g. for this one: `flutter test --dart-define=RANDOM_SEED=2021996283 packages/flame/test/game/transform2d_test.dart` And for other tests: `RANDOM_SEED=2021996283 melos test:seeded`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the initial implementation of the
transform2dRoundTripUncertaintyI tried to approximately figure out how many ops happen in the round trip transform, but it was just an educated guess. Just bumping it by 1 makes the test pass with the given seed2021996283,This also adds a helper to run tests with a specific random seed without modifying the tests, e.g. for this one:
flutter test --dart-define=RANDOM_SEED=2021996283 packages/flame/test/game/transform2d_test.dartAnd for other tests:
RANDOM_SEED=2021996283 melos test:seededChecklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #3692