Skip to content

feat(flame_3d): Allow shader uniform structures use array elements#3878

Merged
wolfenrain merged 1 commit intomainfrom
feat(flame_3d)-allow-shader-uniform-structures-use-array-elements
Mar 24, 2026
Merged

feat(flame_3d): Allow shader uniform structures use array elements#3878
wolfenrain merged 1 commit intomainfrom
feat(flame_3d)-allow-shader-uniform-structures-use-array-elements

Conversation

@wolfenrain
Copy link
Copy Markdown
Contributor

@wolfenrain wolfenrain commented Mar 24, 2026

Description

Added support for array elements in shaders, which allows us to simplify our light system and joint logic

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Copy link
Copy Markdown
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an amazing step forward!
I'd love to support these though:

  • arrays of structs - I didn't recall seeing anything on spec that says it wouldn't work (but it didn't)
  • arbitrary length arrays with SSBOs
    the 16 joint limit can be quite limiting even with my per-node optmization

@wolfenrain
Copy link
Copy Markdown
Contributor Author

This is an amazing step forward! I'd love to support these though:

  • arrays of structs - I didn't recall seeing anything on spec that says it wouldn't work (but it didn't)
  • arbitrary length arrays with SSBOs
    the 16 joint limit can be quite limiting even with my per-node optmization

I kept the implementation the same and we can explore arbitrary length SSBOs later, there was a limit on uniforms that we should get verified to make sure if we can or can not increase the joint limit

@wolfenrain wolfenrain merged commit 9854f13 into main Mar 24, 2026
12 checks passed
@wolfenrain wolfenrain deleted the feat(flame_3d)-allow-shader-uniform-structures-use-array-elements branch March 24, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants