Skip to content

fix(flame_3d)!: Change type on Surface to be non-nullable #3882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolfenrain merged 3 commits into from
Mar 25, 2026
Merged

fix(flame_3d)!: Change type on Surface to be non-nullable #3882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57aeb32
fix(flame_3d)!: Change type on `Surface` to be non-nullable
wolfenrain Mar 25, 2026
c9a194a
fix(flame_3d)!: Change type on `Surface` to be non-nullable
wolfenrain Mar 25, 2026
1a4e402
fix(flame_3d)!: Change type on `Surface` to be non-nullable
wolfenrain Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/flame_3d/lib/src/graphics/graphics_device.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class GraphicsDevice {

_renderPass.bindVertexBuffer(
gpu.BufferView(
surface.resource!,
surface.resource,
offsetInBytes: 0,
lengthInBytes: surface.verticesBytes,
),
Expand All @@ -147,7 +147,7 @@ class GraphicsDevice {

_renderPass.bindIndexBuffer(
gpu.BufferView(
surface.resource!,
surface.resource,
offsetInBytes: surface.verticesBytes,
lengthInBytes: surface.indicesBytes,
),
Expand Down
4 changes: 2 additions & 2 deletions packages/flame_3d/lib/src/resources/mesh/surface.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ enum PrimitiveType {
/// {@template surface}
/// Base surface [Resource], it describes a single surface to be rendered.
/// {@endtemplate}
class Surface extends Resource<gpu.DeviceBuffer?> {
class Surface extends Resource<gpu.DeviceBuffer> {
/// {@macro surface}
Surface({
required List<Vertex> vertices,
Expand Down Expand Up @@ -71,7 +71,7 @@ class Surface extends Resource<gpu.DeviceBuffer?> {
}

@override
gpu.DeviceBuffer? createResource() {
gpu.DeviceBuffer createResource() {
final sizeInBytes = _vertices.lengthInBytes + _indices.lengthInBytes;
resourceSizeInByes = sizeInBytes;
return GpuContextWrapper(gpu.gpuContext).createDeviceBuffer(
Expand Down
Loading