Honor --unit-test-kind work with --unit-bench#434
Merged
djc merged 1 commit intoflamegraph-rs:mainfrom Feb 23, 2026
Merged
Conversation
Commit 512f20c ("Add unit-test-kind option to allow choosing bin or lib") added support for specifying the unit test "kind" when running unit tests. The reasoning brought up there (and solution introduced) applies to unit benches as well. So make --unit-bench honor the value of this option as well.
djc
approved these changes
Feb 23, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 512f20c ("Add unit-test-kind option to allow choosing bin or lib") added support for specifying the unit test "kind" when running unit tests.
The reasoning brought up there (and solution introduced) applies to unit benches as well. So make --unit-bench honor the value of this option as well.