Fix error of processing entry statement. #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiranchandramohan
requested review from
SouraVX,
bryanpkc,
kiranchandramohan,
pawosm-arm and
shivaramaarao
Collaborator
|
Thanks for the patch @yaoliu-hnc and describing the problem also. |
SouraVX
reviewed
May 19, 2021
Collaborator
SouraVX
left a comment
SouraVX
left a comment
There was a problem hiding this comment.
Is it possible to update/document the changes wherever needed ?
pawosm-arm
approved these changes
May 19, 2021
Collaborator
pawosm-arm
left a comment
pawosm-arm
left a comment
There was a problem hiding this comment.
Adding some more rationale in the commit message would be helpful, otherwise it looks OK.
bryanpkc
reviewed
Jun 1, 2021
bryanpkc
reviewed
Jun 1, 2021
Collaborator
|
ping @SouraVX |
bryanpkc
reviewed
Jul 1, 2021
* Compiling error when return type of entry is complex/pointer. Main cause of this problem is that flang2 checks whether the return variable is used as a dummy argument only at the first entry point, so this patch fixes the problem by going through all entry points. In addition, because flang1 changes the storage class of a pointer dummy argument from `SC_DUMMY` to `SC_BASED`, this patch modifies the check for dummy argument in flang2 accordingly. * Inconsistent with Fortran 2008 standard, ISO/IEC JTC 1/SC 22/WG 5/N1830 section-12.6.2.6 (If the characteristics of the result of the function named in the ENTRY statement are the same as the characteristics of the result of the function named in the FUNCTION statement, their result variables identify the same variable, although their names need not be the same). Flang1 currently doesn’t handle functions that are converted to subroutines as the standard specifies, and all entry points simply use the same symbol for the return variable in the field `FVAL`. This patch takes into account all the symbols associated with the return variable, and performs symbol replacement in both the dummy argument list and the AST table.
Collaborator
|
@shivaramaarao If you are okay with this PR, please merge. |
Collaborator
|
This commit causes 3 of the NAG suite test cases to fail: sc7a sr3 sr3e |
shivaramaarao
added a commit
that referenced
this pull request
Sep 17, 2021
This reverts commit 1fbbb03.
xinliu-hnc
pushed a commit
to compiler-dev/flang
that referenced
this pull request
Sep 18, 2021
…compiler#1137). When the entry returns adjustable length character without POINTER attribute, the field NEWARG of the return variable is not set which causes that the return variable in dummy arguments is not replaced. This commit adds the check for the field NEWARG to fix the regression.
kiranchandramohan
pushed a commit
that referenced
this pull request
Sep 22, 2021
This reverts commit 1fbbb03.
xinliu-hnc
pushed a commit
to compiler-dev/flang
that referenced
this pull request
Sep 26, 2021
…piler#1036)"" This reverts commit 4233eb3.
xinliu-hnc
pushed a commit
to compiler-dev/flang
that referenced
this pull request
Sep 26, 2021
…compiler#1137). When the entry returns adjustable length character without POINTER attribute, the field NEWARG of the return variable is not set which causes that the return variable in dummy arguments is not replaced, and it was forgetten to replace the symbol referred in the field CVLEN. This commit fixes the previous two problems and adds the corresponding test cases.
xinliu-hnc
pushed a commit
to compiler-dev/flang
that referenced
this pull request
Sep 26, 2021
…compiler#1137). When the entry returns adjustable length character without POINTER attribute, the field NEWARG of the return variable is not set which causes that the return variable in dummy arguments is not replaced, and the field CVLEN of the return variable also needs to be replaced.
xinliu-hnc
pushed a commit
to compiler-dev/flang
that referenced
this pull request
Oct 8, 2021
…compiler#1137). When the entry returns adjustable length character without POINTER attribute, the field NEWARG of the return variable is not set which causes that the return variable in dummy arguments is not replaced, and the field CVLEN of the return variable also needs to be replaced.
bryanpkc
pushed a commit
that referenced
this pull request
Oct 8, 2021
When the entry returns adjustable length character without POINTER attribute, the field NEWARG of the return variable is not set which causes that the return variable in dummy arguments is not replaced, and the field CVLEN of the return variable also needs to be replaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error of processing entry statement:
Compiling error when return type of entry is complex/pointer/array.
Inconsistent with Fortran 2008 standard, ISO/IEC JTC 1/SC 22/WG 5/N1830
section-12.6.2.6 (If the characteristics of the result of the function
named in the ENTRY statement are the same as the characteristics of the
result of the function named in the FUNCTION statement, their result
variables identify the same variable, although their names need not be
the same).