Skip to content

chore: reduce logging verbosity#86

Merged
moshloop merged 1 commit intomainfrom
pr/logging
Mar 8, 2026
Merged

chore: reduce logging verbosity#86
moshloop merged 1 commit intomainfrom
pr/logging

Conversation

@moshloop
Copy link
Copy Markdown
Member

@moshloop moshloop commented Mar 8, 2026

Summary by CodeRabbit

  • Chores
    • Optimized internal logging across the formatting system to reduce unnecessary output and improve system performance while preserving all functionality.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 8, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 53b850e8-65a7-4742-a9e4-8d42007acdb2

📥 Commits

Reviewing files that changed from the base of the PR and between 820adf8 and f306acb.

📒 Files selected for processing (4)
  • formatters/manager.go
  • formatters/options.go
  • formatters/parser.go
  • formatters/pdf/rsvg_converter.go

Walkthrough

Logging statements have been removed or downgraded across formatter modules. This includes deletion of logger imports and debug-level log calls in core formatting components, plus a log level change in the PDF converter from Info to Debug. No functional changes to formatting logic.

Changes

Cohort / File(s) Summary
Formatter Core Logging Removal
formatters/manager.go, formatters/options.go, formatters/parser.go
Removed logger imports and eliminated multiple verbose logging calls across format resolution, structure application, and column sorting logic. Control flow and formatting behavior remain unchanged.
PDF Converter Log Level Adjustment
formatters/pdf/rsvg_converter.go
Downgraded conversion initialization log from Info to Debug level without affecting error handling or functionality.

Possibly related PRs

  • flanksource/clicky\Misc fixes #64: Modifies the same formatter files (formatters/options.go and formatters/parser.go) with overlapping logging and format resolution changes.
✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pr/logging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@moshloop moshloop merged commit 54badfc into main Mar 8, 2026
12 of 13 checks passed
@moshloop moshloop deleted the pr/logging branch March 8, 2026 11:33
@flankbot
Copy link
Copy Markdown

🎉 This PR is included in version 1.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants