feat: LLM connection types#1234
Merged
Merged
Conversation
yashmehrotra
pushed a commit
that referenced
this pull request
May 6, 2026
…ty middleware into reusable functions Extract HTTP observability logic (HAR collection, HTTP logging) from individual connection types into shared middleware functions in connection/common.go. This eliminates code duplication across AWS, GCS, GKE, OpenSearch, and other connection implementations. New observability functions: - applyHTTPObservability: applies HAR and HTTP logging to a RoundTripper - httpObservabilityMiddleware: returns a middleware for WrapTransport - applyHTTPClientObservability: applies observability to commons HTTP clients - harCollectorMiddleware: HAR-specific middleware with level-aware behavior - httpLoggerWithContent: HTTP request/response logging with configurable detail - metadataHARMiddleware: HAR metadata-only capture for debug-level logging Add context methods for observability configuration: - EffectiveHARLevel, EffectiveLogLevel: resolve per-feature log levels - EffectiveHARCollector: select HAR collector with feature-aware config - HTTPLoggingContent: determine header/body logging for a feature - HARConfig: build feature-specific HAR configuration Update connection implementations to use shared functions, reducing per-connection boilerplate. Add git HTTP transport observability support via configureGitHTTPTransport. Add comprehensive tests for HAR and HTTP logging coexistence, ensuring body restoration across middleware layers. Refs #1234
moshloop
added a commit
that referenced
this pull request
May 7, 2026
…ty middleware into reusable functions Extract HTTP observability logic (HAR collection, HTTP logging) from individual connection types into shared middleware functions in connection/common.go. This eliminates code duplication across AWS, GCS, GKE, OpenSearch, and other connection implementations. New observability functions: - applyHTTPObservability: applies HAR and HTTP logging to a RoundTripper - httpObservabilityMiddleware: returns a middleware for WrapTransport - applyHTTPClientObservability: applies observability to commons HTTP clients - harCollectorMiddleware: HAR-specific middleware with level-aware behavior - httpLoggerWithContent: HTTP request/response logging with configurable detail - metadataHARMiddleware: HAR metadata-only capture for debug-level logging Add context methods for observability configuration: - EffectiveHARLevel, EffectiveLogLevel: resolve per-feature log levels - EffectiveHARCollector: select HAR collector with feature-aware config - HTTPLoggingContent: determine header/body logging for a feature - HARConfig: build feature-specific HAR configuration Update connection implementations to use shared functions, reducing per-connection boilerplate. Add git HTTP transport observability support via configureGitHTTPTransport. Add comprehensive tests for HAR and HTTP logging coexistence, ensuring body restoration across middleware layers. Refs #1234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.