chore: use gavel for test

[adityathebe]

copied over from #1945.

Error: ../../../go/pkg/mod/github.com/flanksource/gavel@v0.0.35/testrunner/ui/assets.go:5:12: pattern dist/testui.js: no matching files found
Error: ../../../go/pkg/mod/github.com/flanksource/gavel@v0.0.35/pr/ui/assets.go:5:12: pattern dist/prui.js: no matching files found
make: *** [Makefile:16: gavel] Error 1
Error: Process completed with exit code 2.

[coderabbitai]

Warning

Rate limit exceeded

@adityathebe has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 52 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 348a898d-d608-4d04-9e9a-ddbe760d8e9f

📥 Commits

Reviewing files that changed from the base of the PR and between 12f15ee and 34b05ce.

📒 Files selected for processing (2)

• Makefile
• Taskfile.yaml

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch build/gavel-test-runner

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch build/gavel-test-runner

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Benchstat (Other)

Base: 12f15eed830aa58278c140b1bf52fb3972d57ab3
Head: 34b05ce41f3865a9ebbe1dddcd6f0b22159ac0ca

✅ No significant performance changes detected

Full benchstat output

goos: linux
goarch: amd64
pkg: github.com/flanksource/duty/bench
cpu: AMD EPYC 7763 64-Core Processor                
                                                       │ bench-base.txt │           bench-head.txt           │
                                                       │     sec/op     │    sec/op     vs base              │
InsertionForRowsWithAliases/external_users.aliases-4       581.1µ ±  7%   580.7µ ±  5%       ~ (p=0.937 n=6)
InsertionForRowsWithAliases/config_items.external_id-4     1.096m ± 11%   1.092m ± 10%       ~ (p=0.937 n=6)
InsertionOfConfigsWithProperties-4                         3.695m ±  1%   3.698m ±  2%       ~ (p=0.589 n=6)
UpdateOfConfigsWithProperties-4                            7.459m ±  4%   7.450m ±  1%       ~ (p=1.000 n=6)
ResourceSelectorConfigs/name-4                             221.3µ ±  4%   221.5µ ±  3%       ~ (p=0.699 n=6)
ResourceSelectorConfigs/name_and_type-4                    235.7µ ±  2%   234.5µ ±  5%       ~ (p=0.937 n=6)
ResourceSelectorConfigs/tags-4                             30.46m ±  5%   29.76m ±  5%       ~ (p=0.310 n=6)
ResourceSelectorQueryBuild/name-4                          42.97µ ±  2%   42.95µ ±  1%       ~ (p=0.485 n=6)
ResourceSelectorQueryBuild/name_and_type-4                 63.37µ ±  1%   63.12µ ±  1%       ~ (p=0.589 n=6)
ResourceSelectorQueryBuild/tags-4                          17.43µ ±  2%   17.14µ ±  2%       ~ (p=0.132 n=6)
geomean                                                    515.4µ         512.7µ        -0.53%

[github-actions]

Benchstat (RLS)

Base: 12f15eed830aa58278c140b1bf52fb3972d57ab3
Head: 34b05ce41f3865a9ebbe1dddcd6f0b22159ac0ca

⚠️ 11 regression(s) detected (threshold: >5%)

Benchmark	Base	Head	Change	p-value
RLS/Sample-15000/config_summary/Without_RLS-4	52.50m	55.38m	+5.49% 🔴	0.002
RLS/Sample-15000/config_types/With_RLS-4	116.0m	121.8m	+4.94%	0.002
RLS/Sample-15000/catalog_changes/Without_RLS-4	4.428m	4.608m	+4.06%	0.002
RLS/Sample-15000/configs/Without_RLS-4	6.304m	6.488m	+2.91%	0.002
RLS/Sample-15000/config_changes/Without_RLS-4	4.402m	4.503m	+2.29%	0.041
RLS/Sample-15000/config_names/Without_RLS-4	11.78m	12.04m	+2.19%	0.002
RLS/Sample-15000/analyzer_types/Without_RLS-4	3.210m	3.263m	+1.65%	0.009
RLS/Sample-15000/config_names/With_RLS-4	116.9m	118.3m	+1.15%	0.002
RLS/Sample-15000/analysis_types/With_RLS-4	3.387m	3.415m	+0.82%	0.002
RLS/Sample-15000/config_detail/Without_RLS-4	3.430m	3.455m	+0.72%	0.026
RLS/Sample-15000/catalog_changes/With_RLS-4	120.4m	121.2m	+0.68%	0.002

✅ 3 improvement(s)

Benchmark	Base	Head	Change	p-value
RLS/Sample-15000/config_detail/With_RLS-4	117.2m	115.9m	-1.16%	0.041
RLS/Sample-15000/config_summary/With_RLS-4	684.2m	677.5m	-0.97%	0.002
RLS/Sample-15000/config_types/Without_RLS-4	3.461m	3.439m	-0.63%	0.026

Failed: 1 benchmark(s) regressed by more than 5%:
RLS/Sample-15000/config_summary/Without_RLS-4: 52.50m -> 55.38m (+5.49%)

Full benchstat output

goos: linux
goarch: amd64
pkg: github.com/flanksource/duty/bench
cpu: AMD EPYC 9V74 80-Core Processor                
                                               │ bench-base.txt │          bench-head.txt           │
                                               │     sec/op     │   sec/op     vs base              │
RLS/Sample-15000/catalog_changes/Without_RLS-4      4.428m ± 1%   4.608m ± 3%  +4.06% (p=0.002 n=6)
RLS/Sample-15000/catalog_changes/With_RLS-4         120.4m ± 0%   121.2m ± 1%  +0.68% (p=0.002 n=6)
RLS/Sample-15000/config_changes/Without_RLS-4       4.402m ± 3%   4.503m ± 1%  +2.29% (p=0.041 n=6)
RLS/Sample-15000/config_changes/With_RLS-4          121.5m ± 1%   121.0m ± 2%       ~ (p=0.818 n=6)
RLS/Sample-15000/config_detail/Without_RLS-4        3.430m ± 1%   3.455m ± 1%  +0.72% (p=0.026 n=6)
RLS/Sample-15000/config_detail/With_RLS-4           117.2m ± 0%   115.9m ± 1%  -1.16% (p=0.041 n=6)
RLS/Sample-15000/config_names/Without_RLS-4         11.78m ± 0%   12.04m ± 3%  +2.19% (p=0.002 n=6)
RLS/Sample-15000/config_names/With_RLS-4            116.9m ± 1%   118.3m ± 1%  +1.15% (p=0.002 n=6)
RLS/Sample-15000/config_summary/Without_RLS-4       52.50m ± 1%   55.38m ± 2%  +5.49% (p=0.002 n=6)
RLS/Sample-15000/config_summary/With_RLS-4          684.2m ± 1%   677.5m ± 0%  -0.97% (p=0.002 n=6)
RLS/Sample-15000/configs/Without_RLS-4              6.304m ± 0%   6.488m ± 1%  +2.91% (p=0.002 n=6)
RLS/Sample-15000/configs/With_RLS-4                 116.9m ± 0%   117.2m ± 0%       ~ (p=0.240 n=6)
RLS/Sample-15000/analysis_types/Without_RLS-4       3.405m ± 3%   3.391m ± 1%       ~ (p=0.699 n=6)
RLS/Sample-15000/analysis_types/With_RLS-4          3.387m ± 0%   3.415m ± 2%  +0.82% (p=0.002 n=6)
RLS/Sample-15000/analyzer_types/Without_RLS-4       3.210m ± 1%   3.263m ± 1%  +1.65% (p=0.009 n=6)
RLS/Sample-15000/analyzer_types/With_RLS-4          3.237m ± 3%   3.246m ± 5%       ~ (p=0.937 n=6)
RLS/Sample-15000/change_types/Without_RLS-4         4.500m ± 1%   4.477m ± 1%       ~ (p=0.093 n=6)
RLS/Sample-15000/change_types/With_RLS-4            4.479m ± 2%   4.455m ± 0%       ~ (p=0.240 n=6)
RLS/Sample-15000/config_classes/Without_RLS-4       2.812m ± 1%   2.808m ± 2%       ~ (p=0.937 n=6)
RLS/Sample-15000/config_classes/With_RLS-4          116.9m ± 0%   117.2m ± 0%       ~ (p=0.132 n=6)
RLS/Sample-15000/config_types/Without_RLS-4         3.461m ± 3%   3.439m ± 1%  -0.63% (p=0.026 n=6)
RLS/Sample-15000/config_types/With_RLS-4            116.0m ± 0%   121.8m ± 2%  +4.94% (p=0.002 n=6)
geomean                                             17.10m        17.27m       +1.02%