This repository was archived by the owner on Jun 14, 2023. It is now read-only.
Closed
Conversation
moshloop
reviewed
Jul 16, 2021
moshloop
reviewed
Jul 16, 2021
Member
|
Can we also add an e2e ? |
9540eb6 to
416c619
Compare
Contributor
Author
|
See the diff PRs created by the tests: |
Contributor
Author
|
Refactored a bit with some more functions. Not sure but let me know about this approach... PRs with this approach: |
Contributor
Author
|
subset of #46 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exposed a different endpoint starting with
/_deleteto let the server know that the request is for delete objectBreaking Change
Testing Notes
Created a gitopsapi object and sent a post request with a object to the delete endpoint to see it gets deleted
GitOpsApi object used:
The post data
The Curl request:
See my testing PR: Kaitou786/test-gitops-api#15
How you can replicate my testing:
How can the reviewer validate this PR?
Links
Issues links or other related resources