fix(reconciler): avoid panic converting unstructured objects

[adityathebe]

runtime.DefaultUnstructuredConverter.FromUnstructured(...) uses reflection to populate every struct field of the destination type as it walks the object graph.

If it encounters an unexported field (lowercase field name), reflection cannot assign to it, and it panics with:

reflect.Value.Set using value obtained using unexported field

---

Our CRDs have unexported fields like

• view.query.http.awsConfig
• playbook.timeout

So the unstructured converter was not “wrong” generally; it’s just incompatible with typed graphs containing private fields in this decode path.

resolves: flanksource/mission-control#2848
resolves: flanksource/mission-control#2864

[adityathebe]

@coderabbitai review

[Copilot]

Pull request overview

This PR updates the reconciler’s unstructured→typed decode path to avoid controller panics caused by reflection attempting to assign into unexported (lowercase) struct fields in CRD Go types.

Changes:

• Replaces runtime.DefaultUnstructuredConverter.FromUnstructured(...) with a JSON marshal→unmarshal conversion to avoid reflection panics on unexported fields.
• Adds error handling for marshal failures and continues emitting “MalformedResource” warning events on conversion errors.

Comments suppressed due to low confidence (1)

reconciler.go:110

• This change is intended to prevent panics caused by unexported fields during unstructured→typed conversion, but the current test suite only covers a schema-shape mismatch (map vs array headers). Add a test case that includes an unexported (lowercase) field in a typed CRD struct (with a corresponding field present in the unstructured object) to ensure reconciliation no longer panics and the controller keeps running.

	obj := PT(new(T))
	payload, err := json.Marshal(raw.Object)
	if err != nil {
		logger.Errorf("[kopper] malformed resource %s: %v", resourceName, err)
		r.Events.Event(raw, "Warning", "MalformedResource",
			fmt.Sprintf("Resource spec does not match expected schema: %v", err))
		return ctrl.Result{}, fmt.Errorf("failed to marshal unstructured resource: %w", err)
	}

	if err := json.Unmarshal(payload, obj); err != nil {
		logger.Errorf("[kopper] malformed resource %s: %v", resourceName, err)
		r.Events.Event(raw, "Warning", "MalformedResource",
			fmt.Sprintf("Resource spec does not match expected schema: %v", err))
		return ctrl.Result{}, fmt.Errorf("failed to convert unstructured to typed object: %w", err)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.