fix: scope plugin sessions to active config targets#28
Merged
Conversation
Arthas, Inspektor Gadget, and SQL Server trace sessions could leak across config pages because their in-process registries were listed globally. Scope Arthas and Inspektor sessions by the pods resolved from the active config item, validate session actions against that target set, and use SQL Server trace configItemId for trace list/get/stop/delete. Update UI cache keys and selection behavior so stale sessions are not shown after switching configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arthas, Inspektor Gadget, and SQL Server trace sessions could leak across config pages because their in-process session registries were listed globally.
Scope Arthas and Inspektor sessions by the pods resolved from the active config item, and validate session actions against that same target set.
SQL Server traces already record configItemId; use it to filter and validate trace list/get/stop/delete operations. UI cache keys and selection logic were updated so stale sessions are not shown after switching configs.