Skip to content

Pending upgrade release fix#495

Merged
yalosev merged 10 commits into
mainfrom
pending-upgrade-release-fix
Aug 29, 2024
Merged

Pending upgrade release fix#495
yalosev merged 10 commits into
mainfrom
pending-upgrade-release-fix

Conversation

@miklezzzz
Copy link
Copy Markdown
Contributor

@miklezzzz miklezzzz commented Aug 13, 2024

Overview

The following changes are introduced:

  1. go was updated to 1.20 to support newer versions on the dependencies. (random seed generation is omitted as in 1.20 it's provided implicitly);
  2. dockerfile was updated to provide up-to-date build instructions;
  3. helm module logic was updated so as to apply helm upgrade every time when the module's release isn't in deployed state. All other release states are regarded as faulty.
  4. helm resource monitor was updated to check not only for absent resources of the release, but the current release state (see previous point);
  5. release recovery from pending state logic was updated to delete faulty revision and do helm upgrade if helm storage driver is Secrets or ConfigMaps. This way there is no need to do rollback and upgrade, thus, avoiding multiple consequent redeploys. If other type of driver is in use, standard rollback procedure is applied.
  6. ListReleasesName method of the helm3lib package was fixed to list not only releases in deployed or failed states (by default), but all releases. It makes purge procedure slightly more robust.

What this PR does / why we need it

Closes #481
Closes #496

Special notes for your reviewer

Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
@miklezzzz miklezzzz added the enhancement New feature or request label Aug 13, 2024
@miklezzzz miklezzzz self-assigned this Aug 13, 2024
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
…her than deployed

Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
@miklezzzz miklezzzz requested a review from yalosev August 20, 2024 10:41
@miklezzzz miklezzzz marked this pull request as ready for review August 20, 2024 10:41
@miklezzzz miklezzzz force-pushed the pending-upgrade-release-fix branch 2 times, most recently from 1f83704 to 703669e Compare August 26, 2024 10:20
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
@miklezzzz miklezzzz force-pushed the pending-upgrade-release-fix branch from 703669e to 6207246 Compare August 26, 2024 10:21
@yalosev yalosev merged commit c937de3 into main Aug 29, 2024
@yalosev yalosev deleted the pending-upgrade-release-fix branch August 29, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module's helm release in uninstalling state doesn't get purged by the operator helm client: modules may stuck in pending-upgrade periodically

2 participants