Merged
Conversation
Signed-off-by: Ilya Lesikov <ilya@lesikov.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…on of labels Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…tation Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…er implementation Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
… from release annotations Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…ues method Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…e management and label handling Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
… release management - Introduced NelmActions interface for better abstraction of release operations. - Refactored NelmClient to utilize the new interface for actions like ReleaseGet, ReleaseInstall, and others. - Updated tests to accommodate the new structure and ensure functionality remains intact. Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…s purpose and behavior Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…d code organization
- Added missing import for utils in nelm_test.go.
- Changed map types from `map[string]interface{}` to `map[string]any` for better type safety.
- Removed unused test client creation functions in nelm_test.go.
- Improved release names handling in ListReleasesNames method in nelm.go.
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
- Updated logging to include chart name when release name is empty, improving clarity in logs. Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…easesNames method - Simplified ListReleasesNames by removing the check for empty release names, as it is no longer needed. Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
- Replaced string concatenation with strings.Builder for improved performance in the Render method of NelmClient. Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
- Updated NewNelmClient to eliminate the actions parameter, defaulting to DefaultNelmActions. - Adjusted tests in nelm_test.go to set actions after client creation for consistency. Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
- Changed nelmLog.Default to nelmLog.DefaultNull in NewNelmClient for improved logging behavior. Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
- Updated InitHelmClientFactory to initialize Nelm client when USE_NELM environment variable is set. - Enhanced tests to verify detection of Nelm client and its initialization. Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…andling Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…ion only in release metadata Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…eteRelease Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…mbined-nelm-features Signed-off-by: kerimov <brileyforbusiness@gmail.com> # Conflicts: # go.sum
…combined-nelm-features Signed-off-by: kerimov <brileyforbusiness@gmail.com> # Conflicts: # go.sum
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
…combined-nelm-testing
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
ldmonster
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Trying to use nelm as a replacement for helm
What this PR does / why we need it
Nelm intergration