Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Concurrent transactions produce artery messages with sequential IDs, but
after_commitcallbacks fire in unpredictable order. This causes incorrect_previous_indexvalues — consumers see a broken chain and drop valid messages. The previous fix (#82) usedFOR UPDATElocks onartery_model_infosto serialize publishing, which worked correctly but caused high lock contention under high concurrency.Solution
Replace inline publishing with an outbox pattern:
artery_messagesdirectly in model callbacks (after_create/after_update/after_destroy), inside the model transaction. No locks needed.bundle exec artery-publisher) pollsartery_messagesand publishes to NATS in strictidorder, guaranteeing a correct_previous_indexchain.last_published_idonartery_model_infos, protected byFOR UPDATE(only between publisher instances, not on the hot path).concurrent-rubythread pool.Configuration
Two publishing modes controlled by
inline_publish(default:true):after_commit, no extra process needed. Suitable for development.config.inline_publish = falseand runartery-publisher. Recommended for production.