Skip to content

fix: log stderr for hook --config #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diafour merged 1 commit into from
Feb 20, 2021
Merged

fix: log stderr for hook --config #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/hook/hook_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package hook
import (
"fmt"
"os"
"os/exec"
"path/filepath"
"sort"
"strings"
Expand Down Expand Up @@ -141,6 +142,9 @@ func (hm *hookManager) loadHook(hookPath string) (hook *Hook, err error) {
configOutput, err := hm.execCommandOutput(hook.Name, hm.workingDir, hookPath, envs, []string{"--config"})
if err != nil {
hookEntry.Errorf("Hook config output:\n%s", string(configOutput))
if ee, ok := err.(*exec.ExitError); ok && len(ee.Stderr) > 0 {
hookEntry.Errorf("Hook config stderr:\n%s", string(ee.Stderr))
}
return nil, fmt.Errorf("cannot get config for hook '%s': %s", hookPath, err)
}

Expand Down Expand Up @@ -184,6 +188,7 @@ func (hm *hookManager) execCommandOutput(hookName string, dir string, entrypoint
envs = append(os.Environ(), envs...)
cmd := executor.MakeCommand(dir, entrypoint, args, envs)
cmd.Stdout = nil
cmd.Stderr = nil

debugEntry := log.WithField("hook", hookName).
WithField("cmd", strings.Join(cmd.Args, " "))
Expand Down