Merged
Conversation
diafour
force-pushed
the
feat_kube_client_custom_metrics
branch
from
261d8a0 to
7ce44d3
Compare
diafour
force-pushed
the
feat_kube_client_custom_metrics
branch
from
7ce44d3 to
9b8bc50
Compare
diafour
force-pushed
the
feat_kube_client_custom_metrics
branch
from
3511752 to
b766356
Compare
nabokihms
approved these changes
Mar 16, 2021
Timeout for 'main' kube client resets Watcher sessions. So, separate kube client with timeout for object patcher is the best what we can do without huge upgrade to 0.20.
diafour
force-pushed
the
feat_kube_client_custom_metrics
branch
from
b766356 to
ab305a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Custom labels for metrics exported by the kube client.
What this PR does / why we need it
It is needed to distinguish metrics when multiply clients are in use. addon-operator needs this.
Special notes for your reviewer
Does this PR introduce a user-facing change?