Skip to content

[webhook] Add log verbosity#854

Merged
ldmonster merged 8 commits intomainfrom
feature/log-verbosity
Mar 24, 2026
Merged

[webhook] Add log verbosity#854
ldmonster merged 8 commits intomainfrom
feature/log-verbosity

Conversation

@riptide-01
Copy link
Member

@riptide-01 riptide-01 commented Mar 20, 2026

Overview

Increased logs verbosity.

Changes made:

  • Some log messages have been rewritten
  • Additional fields have been added for display in logs
  • Instead of using the default logger, logger of shell-operator has been forwarded
  • Wrapping of returned errors
  • Messages have been added for errors with status code 400
  • Fixed a bug in tests where the shell-operator was initialized without a logger, resulting in a nil pointer dereference error.

What this PR does / why we need it

These changes are necessary to make logs easier to read and improve debugging.

Special notes for your reviewer

  • Changes tested manually

Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>
@riptide-01 riptide-01 requested a review from ldmonster March 20, 2026 10:30
@riptide-01 riptide-01 self-assigned this Mar 20, 2026
@riptide-01 riptide-01 added the enhancement New feature or request label Mar 20, 2026
Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>
Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>
Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>
@riptide-01 riptide-01 marked this pull request as ready for review March 23, 2026 09:47
Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>
Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>
Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR increases logging verbosity and consistency across the webhook stack by injecting the shell-operator logger through webhook managers/handlers/server, improving structured fields, and wrapping errors to add context for easier debugging.

Changes:

  • Add logger plumbing via constructors/options for webhook server, managers, handlers, and webhook resources.
  • Rewrite/augment log messages with additional structured fields; wrap returned errors with context.
  • Add explicit 400 responses for invalid webhook requests; fix tests to initialize shell-operator with a logger.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
test/hook/context/context_combiner.go Update test helper to construct ShellOperator via constructor and provide a nop logger/metric storage to avoid nil logger deref.
pkg/webhook/server/server_test.go Update test to use NewWebhookServer with a nop logger.
pkg/webhook/server/server.go Add WebhookServer.Logger and NewWebhookServer constructor; use injected logger in Start().
pkg/webhook/conversion/manager.go Add logger option/default; forward logger to handler/server; wrap errors with context.
pkg/webhook/conversion/handler.go Use injected logger; add request-scoped fields; add 400 responses for invalid input; wrap handler errors.
pkg/webhook/conversion/crd_client_config.go Wrap CRD get/update errors with context.
pkg/webhook/admission/resource.go Inject logger into resources; improve logging and wrap list errors.
pkg/webhook/admission/manager.go Add logger option/default; forward logger to handler/server/resources; wrap errors with context.
pkg/webhook/admission/handler.go Use injected logger; add request-scoped fields; add 400 responses for invalid input; wrap handler errors.
pkg/shell-operator/operator.go Switch some logs to op.logger; adjust admission event logging fields; tweak conversion failure message.
pkg/shell-operator/bootstrap.go Pass shell-operator logger into admission/conversion webhook managers.
pkg/hook/hook_manager.go Replace global logging with manager logger and improve structured logging fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>
@ldmonster ldmonster merged commit 4dd9f2c into main Mar 24, 2026
9 checks passed
@ldmonster ldmonster deleted the feature/log-verbosity branch March 24, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants