[2.0 beta2] Flag permission in user context not working poperly

[GreXXL]

Current Behavior

Flags persmission seem not to work properly. Users do see the moderation context instead of the notice that a post has been flagged

Steps to Reproduce

Go to a post - flag the post with user permissions

Expected Behavior

Screenshots

No response

Environment

Flarum core: 2.0.0-beta.2
PHP version: 8.2.27
MySQL version: 10.3.39-MariaDB-0ubuntu0.20.04.2
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, bz2, calendar, ctype, hash, filter, ftp, gettext, gmp, json, iconv, SPL, pcntl, random, readline, Reflection, session, standard, mbstring, SimpleXML, sockets, tokenizer, xml, mysqlnd, bcmath, curl, dba, dom, enchant, fileinfo, gd, imagick, imap, intl, ldap, exif, mysqli, odbc, PDO, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, pspell, redis, soap, sodium, sqlite3, sysvmsg, sysvsem, sysvshm, tidy, xmlreader, xmlwriter, xsl, zip, Zend OPcache
+------------------------+---------------+--------+
| Flarum Extensions | | |
+------------------------+---------------+--------+
| ID | Version | Commit |
+------------------------+---------------+--------+
| flarum-flags | v2.0.0-beta.2 | |
| flarum-approval | v2.0.0-beta.2 | |
| flarum-tags | v2.0.0-beta.2 | |
| flarum-suspend | v2.0.0-beta.2 | |
| flarum-subscriptions | v2.0.0-beta.2 | |
| flarum-sticky | v2.0.0-beta.2 | |
| flarum-statistics | v2.0.0-beta.2 | |
| flarum-package-manager | v2.0.0-beta.2 | |
| flarum-nicknames | v2.0.0-beta.2 | |
| flarum-messages | v2.0.0-beta.2 | |
| flarum-mentions | v2.0.0-beta.2 | |
| flarum-markdown | v2.0.0-beta.2 | |
| flarum-lock | v2.0.0-beta.2 | |
| flarum-likes | v2.0.0-beta.2 | |
| flarum-lang-english | v2.0.0-beta.2 | |
| flarum-gdpr | v2.0.0-beta.2 | |
| flarum-emoji | v2.0.0-beta.2 | |
| flarum-bbcode | v2.0.0-beta.2 | |
+------------------------+---------------+--------+

Output of php flarum info

Output of "php flarum info", run this in terminal in your Flarum directory.

Possible Solution

No response

Additional Context

No response

[SychO9]

This is an interesting one, 1.x explicitly allows users to view their own flags, if you go to /api/flags as a normal user you can view your own flags. Except it hides them from the UI at the same time, looks like it was left in a half-baked state.

Flarum 2.x's code assumed based on the explicit allowing of flag creators to see their own flags that, well, they can.

I'll completely disallow viewing your own flags.

[GreXXL]

I'll completely disallow viewing your own flags.

I am split in my opinion. On the one hand it's awesome that you can see that you have already reported something (but it hasn't been addressed yet). On the other hand having options there that just result in a permission error does not make much sense.

On the other hand your proposed change would pretty much restore the current frontend behaviour people are used to.