-
-
Notifications
You must be signed in to change notification settings - Fork 861
[1.x] fix(tags): defer policy if min primary & secondary tags 0 #4277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deferring it rather then force allowing in that case allows other policies to take action. Consider this more of a POC
|
Tentatively marking this ready for review to gather some feedback on the general approach. As mentioned for now I'm treating this PR more of quick POC to address the issue. If general feedback is good I can then move on to add tests and work on a 2.x PR as well |
|
Good catch @DavideIadeluca Personally I'm happy with the approach for sure. As you say, we'd need to test around this to ensure we don't cause issues elsewhere, but I suspect this will be fine. Some CI tests here would be ideal 👍 |
imorland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DavideIadeluca great work!
1.xequivalent to #4279Fixes #4276
Changes proposed in this pull request:
Early return if minimum number of primary and secondary tags is 0. Deferring it rather then force allowing in that case allows other policies to take action
Reviewers should focus on:
Consider this more of a POC. Unsure yet if this PR causes regression in other parts
Screenshot
Necessity
Confirmed
composer test).Required changes: