Conversation
…atic analysis Intelephense reports "Undefined method 'getDriverName'" (and similar) because the `database` property and `TestCase::database()` return `ConnectionInterface`, which doesn't declare concrete `Connection` methods. Keep `ConnectionInterface` as the actual PHP type so custom connection implementations (e.g. swapping drivers in tests) remain compatible at runtime, but add `@var Connection|null` / `@return Connection` PHPDoc annotations so Intelephense and PHPStan resolve the concrete methods. Fixes #4432 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
imorland
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnectionInterfaceas the actual PHP type onBootstrapper::$databaseandTestCase::database()so custom connection implementations remain compatible at runtime@var Connection|nulland@return ConnectionPHPDoc annotations so Intelephense / PHPStan resolve concrete methods (e.g.getDriverName(),getSchemaBuilder())Fixes #4432
Test plan
$this->database()->getDriverName()in test files🤖 Generated with Claude Code