Conversation
When an initializer throws, the error is deferred into a closure and fired after mount(). The closure was reading this.currentInitializerExtension at call time — by which point the property holds the last initializer's name, not the one that threw. Capture the name into a local const at catch time so each closure closes over its own immutable value. Mirrors what extend.ts already does correctly. Fixes #4293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4293.
When an initializer throws, the error is deferred into a
caughtInitializationErrorsclosure and fired aftermount()completes. The closure was readingthis.currentInitializerExtensionat call time — by which point the property holds the last initializer's name, not the one that threw. So every error message incorrectly blamed the final extension in the boot sequence.The fix is a one-liner: capture
this.currentInitializerExtensioninto a localconstinside thecatchblock before creating the closure, so each closure closes over its own immutable value.extend.tsalready does this correctly (const extension = app.currentInitializerExtensionat line ~34). Thecatchblock was just not updated to match whencurrentInitializerExtensionwas introduced in #4134.Test plan
initialize(), and asserts the error closure namesbad-ext(the throwing extension), notgood-ext(the last one to run)yarn testinframework/core/js/