[1.x] fix: re-sort extension order during migrate#4512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4493 to 1.x. Fixes #4494.
When an extension update adds or changes
optional-dependenciesin itscomposer.json, the stored boot order inextensions_enabledis not updated until an extension is manually disabled and re-enabled.Root cause:
setEnabledExtensions()— which re-sorts and persists the order — is only called during enable/disable. Themigratecommand reads the stored order viagetEnabledExtensions()but never re-sorts it.Fix: Add a
syncExtensionOrder()public method toExtensionManagerthat re-sorts and persists the current enabled extension list, and call it at the start ofMigrateCommand::upgrade().