[1.x] fix(tags): exclude bypassTagCounts from DiscussionPolicy catch-all#4538
Merged
[1.x] fix(tags): exclude bypassTagCounts from DiscussionPolicy catch-all#4538
Conversation
The catch-all `can()` method in DiscussionPolicy intercepted every discussion ability, including the `bypassTagCounts` meta-permission, and checked for a per-tag variant (e.g. `tag6.discussion.bypassTagCounts`) that never exists. This caused the permission check to always deny non-admin users, even when they had been explicitly granted `bypassTagCounts`, whenever the discussion was in a restricted tag. Fixes #4537
imorland
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4537
The catch-all
can()method inDiscussionPolicyintercepted every discussion ability and checked for a per-tag variant (e.g.tag6.discussion.bypassTagCounts) that never exists. This causedbypassTagCountsto always deny non-admin users when the discussion was in a restricted tag.The fix returns early from the catch-all when
$ability === 'bypassTagCounts', letting the normal global permission check handle it instead.