[2.x] feat: all images validated equally#4579
Merged
imorland merged 2 commits intoflarum:2.xfrom Apr 17, 2026
Merged
Conversation
luceos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4429
The problem
None of the files uploaded through the admin area are validated against "normal" rules. This includes the Logo, favicon and Logo dark variant. As a consequence no proper validation errors are thrown.
The solution
Instead of patching just the Logo controller I refactored the existing AvatarUploader to become an ImageValidator for generic use.
The considerations
The independent validator classes are still required because we have an extender Validator that allows regulating individual validators. As such I could not refactor into one class.
The abstract
UploadImageControllerin the API was refactored to automatically pick up on a specified$validatorclass automatically and run the validation immediately.This ought to be backward compatible.