[2.x] fix: correct mobile layout and alignment of avatar in edited posts#4610
Open
huoxin233 wants to merge 2 commits intoflarum:2.xfrom
Open
[2.x] fix: correct mobile layout and alignment of avatar in edited posts#4610huoxin233 wants to merge 2 commits intoflarum:2.xfrom
huoxin233 wants to merge 2 commits intoflarum:2.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Changes proposed in this pull request:
When a user edits an existing post on a mobile device (
@media @phone), the layout is broken:(reproducible on discuss.flarum.org)
This PR add a CSS rule to
.Post-header .Post-avatarwhenever.CommentPost.editingis active in mobile view..Post-side .Post-avatarfromdisplay: block;todisplay: inline-flex;inside the editing block.Misalignment of badges should be fix in #4582
Reviewers should focus on:
Screenshot
Before:

After:

Necessity
Confirmed
composer test).Required changes: