Skip to content

add unicode support in slugs #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thecotne wants to merge 1 commit into from
Closed

add unicode support in slugs #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions js/lib/utils/string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,28 @@ export function truncate(string, length, start = 0) {
}

/**
* Create a slug out of the given string. Non-alphanumeric characters are
* converted to hyphens.
* Create a slug out of the given string.
*
* nonsafe URL characters are converted to hyphens.
*
* @param {String} string
* @return {String}
*/
export function slug(string) {
return string.toLowerCase()
.replace(/[^a-z0-9]/gi, '-')
.replace(/-+/g, '-')
.replace(/-$|^-/g, '') || '-';
// Regex for finding the nonsafe URL characters (many need escaping): & +$,:;=?@"#{}|^~[`%!']./()*\
var nonsafeChars = /[& +$,:;=?@"#{}|^~[`%!'\]\.\/\(\)\*\\]/g;

// Note: we trim hyphens after truncating because truncating can cause dangling hyphens.
// Example string: // " ⚡⚡ Don't forget: URL fragments should be i18n-friendly, hyphenated, short, and clean."
string = string.trim() // "⚡⚡ Don't forget: URL fragments should be i18n-friendly, hyphenated, short, and clean."
.replace(/\'/gi, '') // "⚡⚡ Dont forget: URL fragments should be i18n-friendly, hyphenated, short, and clean."
.replace(nonsafeChars, '-') // "⚡⚡-Dont-forget--URL-fragments-should-be-i18n-friendly--hyphenated--short--and-clean-"
.replace(/-{2,}/g, '-') // "⚡⚡-Dont-forget-URL-fragments-should-be-i18n-friendly-hyphenated-short-and-clean-"
.substring(0, 64) // "⚡⚡-Dont-forget-URL-fragments-should-be-i18n-friendly-hyphenated-"
.replace(/^-+|-+$/gm, '') // "⚡⚡-Dont-forget-URL-fragments-should-be-i18n-friendly-hyphenated"
.toLowerCase(); // "⚡⚡-dont-forget-url-fragments-should-be-i18n-friendly-hyphenated"

return $string || '-';
}

/**
Expand Down
24 changes: 16 additions & 8 deletions src/Util/Str.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,26 @@ class Str
/**
* Create a slug out of the given string.
*
* Non-alphanumeric characters are converted to hyphens.
* nonsafe URL characters are converted to hyphens.
*
* @param string $str
* @param string $string
* @return string
*/
public static function slug($str)
public static function slug($string)
{
$str = strtolower($str);
$str = preg_replace('/[^a-z0-9]/i', '-', $str);
$str = preg_replace('/-+/', '-', $str);
$str = preg_replace('/-$|^-/', '', $str);
// Regex for finding the nonsafe URL characters (many need escaping): & +$,:;=?@"#{}|^~[`%!']./()*\
$nonsafeChars = '/[& +$,:;=?@"#{}|^~[`%!\'\]\.\/\(\)\*\\]/g';

return $str ?: '-';
// Note: we trim hyphens after truncating because truncating can cause dangling hyphens.
// Example string: // " ⚡⚡ Don't forget: URL fragments should be i18n-friendly, hyphenated, short, and clean."
$string = trim($string); // "⚡⚡ Don't forget: URL fragments should be i18n-friendly, hyphenated, short, and clean."
$string = preg_replace('/\'/gi', '', $string); // "⚡⚡ Dont forget: URL fragments should be i18n-friendly, hyphenated, short, and clean."
$string = preg_replace($nonsafeChars, '-', $string); // "⚡⚡-Dont-forget--URL-fragments-should-be-i18n-friendly--hyphenated--short--and-clean-"
$string = preg_replace('/-{2,}/g', '-', $string); // "⚡⚡-Dont-forget-URL-fragments-should-be-i18n-friendly-hyphenated-short-and-clean-"
$string = substr($string, 0, 64); // "⚡⚡-Dont-forget-URL-fragments-should-be-i18n-friendly-hyphenated-"
$string = preg_replace('/^-+|-+$/gm', '', $string); // "⚡⚡-Dont-forget-URL-fragments-should-be-i18n-friendly-hyphenated"
$string = strtolower($string); // "⚡⚡-dont-forget-url-fragments-should-be-i18n-friendly-hyphenated"

return $string ?: '-';
}
}