Add "TagLabel--child" class to aid with custom theming#114
Add "TagLabel--child" class to aid with custom theming#114askvortsov1 merged 10 commits intoflarum:masterfrom
Conversation
|
Instead of having it equal Also - make sure you use single quotes for strings. |
Sounds good. I'll do
Oops. I'm gonna make a PR to add |
|
why not use a class instead ? |
|
Actually, what @SychO9 makes more sense, my bad. We use classes for mostly everything, stuff like if the Post was made by the current user, etc... so |
|
Ah, that's true. I've always been a fan of data attributes over classes for identifying features like this (generally because they're tstable with |
I've run into issues with theming tags in discussion lists and other areas as there's nothing in the DOM that can be used to differentiate between primary/secondary/child tags.
Adding this custom data attribute would be super helpful for theming, especially with extensions like night mode where keeping the tags the same colour between light/dark could make them unreadable.
PS: The repo seems to be missing the Prettier stuff that other core repos have. Should I PR it all in?