Azure attestation tdx-quote must be based on td_report with input data#91
Merged
Azure attestation tdx-quote must be based on td_report with input data#91
Conversation
* main: Rm unneeded configuration in Makefile build environment following review Run on a github runner rather than WarpBuild Use reproducible version of binary in deb package Apply suggestions from review and add script to check reproducibility Rm workflow stage for docker Add release workflow Tidy makefile Add makefile and dockerfile for release builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the Azure attestation code which was revealed when attempting attestation verification on a test deployment for Buildernet.
The issue is that the
td_reportused in the quote retrieved via idms did not have the user data as input. Meaning we got a different HCL report hash to the HCL report which did include user data.I think the reason this did not cause tests to fail is that our test attestations had
[0u8; 64]as input data - meaning they matched atd_reportwith no input given.If this works, we should probably get some extra test data with other input values for testing future changes.