Code formatting cleanup, 'make lint' should fail on formatting errors #266
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the make lint command to fail when code formatting issues are detected, rather than just displaying them. Previously, gofmt and gofumpt would only print formatting differences without causing the lint target to fail.
Key Changes:
- Modified
gofmtandgofumptcommands to capture output and exit with error code 1 if formatting issues are found
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+33
to
+34
| output=$$(gofmt -d -s .) && [ -z "$$output" ] || { echo "$$output"; exit 1; } | ||
| output=$$(gofumpt -d -extra .) && [ -z "$$output" ] || { echo "$$output"; exit 1; } |
There was a problem hiding this comment.
The shell logic for capturing and checking formatter output is duplicated. Consider extracting this pattern into a shell function or variable at the top of the Makefile to improve maintainability and make future formatter additions easier.
ferranbt
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.