Fix linting errors, and require staticcheck to pass #276
+5
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enforces stricter linting requirements by making staticcheck a mandatory pass in the CI pipeline, and fixes the linting errors that were preventing staticcheck from passing. The key changes remove dead code and fix an ineffective break statement.
- Removed unused
waitForChainAlivefunction - Fixed break statement to properly exit outer loop
- Enabled staticcheck as a required check in the Makefile
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| playground/watchers.go | Removed unused waitForChainAlive function and fixed break statement to properly exit labeled loop |
| Makefile | Removed ` |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
metachris
force-pushed
the
staticcheck2
branch
from
e060006 to
3c2777b
Compare
metachris
force-pushed
the
staticcheck2
branch
from
3c2777b to
88bb557
Compare
canercidam
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also uses warpbuild for remaining CI steps.