Improve custom recipe experience and testing

[canercidam]

• Add recipe flags to generate cmd to support conditional recipe generation
• Add --retries flag to test command and improve timeout flag usage
• Add setup field to custom YAML recipes to setup the environment first before running the playground - arrives with --skip-setup option
• Resolve relative host_paths to absolute paths to run local binaries from custom recipes
• Enable port overriding from the custom recipe

These are improvements made and discovered during the experimentation with op-rbuilder repo, for running locally and in CI.

[claude]

Claude finished @canercidam's task in 2m 45s —— View job

---

Review of PR #379

• Read PR diff and changed files
• Review main.go changes
• Review playground/local_runner.go changes
• Review playground/local_runner_lifecycle.go changes
• Review playground/manifest.go changes
• Review playground/recipe_yaml.go changes
• Review playground/test_tx.go changes
• Post review summary

---

Summary

Found 3 issues, 1 of which is a likely crash:

1. Bug (crash at startup): generateCmd.Flags().AddFlagSet(recipe.Flags()) in main.go:610 adds flags from all recipes to a single command. Recipes share flag names (e.g. --block-time in both L1 and OpStack, all L1 flags duplicated via BuilderNet). pflag panics on flag redefinition, so this will crash the binary when the generate command is initialized. (inline comment)

2. Path resolution inconsistency: filepath.Abs in recipe_yaml.go resolves host_path relative to CWD, not the recipe directory. Other relative paths in the same file use recipeDir. This will break when the user's CWD differs from the recipe file's location. (inline comment)

3. Minor — protocol not updated on port override: WithPort in manifest.go updates the port number but returns before updating the protocol. Not a problem for current callers (all use the default TCP), but makes the API incorrect. (inline comment)

The test_tx.go changes (timeout/retries) and local_runner_lifecycle.go (setup commands) look correct.

[claude]

Claude finished @canercidam's task in 5m 57s —— View job

---

Re-review of PR #379 (after feedback commit 76970b1)

• Read updated diff and changed files
• Review each changed file for issues
• Post review summary

---

Summary

The feedback commit addresses two of the three issues from my previous review:

• WithPort protocol update — Fixed. p.Protocol = protocol is now set when overriding the port number (manifest.go:530).
• host_path resolution — Fixed. Relative paths now resolve via filepath.Join(recipeDir, ...) instead of bare filepath.Abs (recipe_yaml.go:476-480, 657-661).
• generateCmd flag duplication — Acknowledged as deferred (main.go:612). This will panic at startup due to conflicting --block-time flag types across recipes (Duration in L1, Uint64 in OpStack). Since it's marked as a known issue, no further comment.

No new issues found in the updated diff. The rest of the changes (setup commands, test retries/timeout, skip-setup flag) look correct.

---