Skip to content

fix: display extra data as text instead of hex in test output#387

Merged
canercidam merged 1 commit intomainfrom
fryd/fix-test-extra-data
Mar 2, 2026
Merged

fix: display extra data as text instead of hex in test output#387
canercidam merged 1 commit intomainfrom
fryd/fix-test-extra-data

Conversation

@fkondej
Copy link
Contributor

@fkondej fkondej commented Mar 2, 2026

No description provided.

@fkondej fkondej self-assigned this Mar 2, 2026
@fkondej fkondej requested a review from canercidam as a code owner March 2, 2026 11:35
@claude
Copy link
Contributor

claude bot commented Mar 2, 2026

Claude finished @fkondej's task in 53s —— View job


Review of PR #387

  • Gather context and read changed files
  • Analyze code changes
  • Post review feedback

Summary: Clean, small fix that switches extra data display from hex to human-readable text and simplifies the comparison using bytes.Equal. One issue noted:

  • Error message loses actual value — the error on mismatch now only shows the expected extra data, dropping the actual value. This makes debugging harder when the check fails. Left an inline suggestion to include both expected and actual values in the error message.

@canercidam canercidam merged commit b09631f into main Mar 2, 2026
13 checks passed
@canercidam canercidam deleted the fryd/fix-test-extra-data branch March 2, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants