You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The README improvements are well done — better structured Quick Start, new Logs section, added prerequisites (qemu-utils, unzip), and the health check step before verification. Merging sync.sh into build.sh simplifies the workflow. No stale references to the deleted sync.sh remain.
Two issues in build.sh worth addressing:
Missing .mkosi_version guard (line 18): cat will fail with a cryptic error if the file doesn't exist in the cloned repo. A check with a clear error message would improve the developer experience.
Stale mkosi version (line 22): The check only tests if the mkosi binary exists, not whether it matches the commit in .mkosi_version. After an update to flashbots-images, the old mkosi would keep being used.
PR Review: Improve buildernet/mkosi README (re-review after sync)
Gather context and read updated changes
Review changes and provide feedback
Re-reviewed after the latest push. The changes look good:
README.md: Better Quick Start flow (health check before verification), added missing prerequisites (qemu-utils, unzip), new Logs section, clearer "Building Your Own Image" section, inline session-name hint.
build.sh: Cleanly absorbs the clone logic from sync.sh, sets up mkosi from .mkosi_version, defaults branch to main (overridable via FLASHBOTS_IMAGES_BRANCH).
sync.sh deleted: No stale references remain.
No issues found. The previous review comments about .mkosi_version guards and stale-version checks were acknowledged by the author as out of scope for a reference script — that's reasonable given set -eu provides basic error handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.