Skip to content

Improve buildernet/mkosi readme#388

Merged
canercidam merged 3 commits intomainfrom
fryd/improve-buildernet-mkosi-readme
Mar 3, 2026
Merged

Improve buildernet/mkosi readme#388
canercidam merged 3 commits intomainfrom
fryd/improve-buildernet-mkosi-readme

Conversation

@fkondej
Copy link
Contributor

@fkondej fkondej commented Mar 2, 2026

No description provided.

@fkondej fkondej self-assigned this Mar 2, 2026
@fkondej fkondej requested a review from canercidam as a code owner March 2, 2026 12:00
@claude
Copy link
Contributor

claude bot commented Mar 2, 2026

Claude finished @fkondej's task in 1m 11s —— View job


PR Review: Improve buildernet/mkosi README

  • Gather context and read changed files
  • Review changes and provide feedback

The README improvements are well done — better structured Quick Start, new Logs section, added prerequisites (qemu-utils, unzip), and the health check step before verification. Merging sync.sh into build.sh simplifies the workflow. No stale references to the deleted sync.sh remain.

Two issues in build.sh worth addressing:

  1. Missing .mkosi_version guard (line 18): cat will fail with a cryptic error if the file doesn't exist in the cloned repo. A check with a clear error message would improve the developer experience.

  2. Stale mkosi version (line 22): The check only tests if the mkosi binary exists, not whether it matches the commit in .mkosi_version. After an update to flashbots-images, the old mkosi would keep being used.

@claude
Copy link
Contributor

claude bot commented Mar 2, 2026

Claude finished @fkondej's task in 1m 14s —— View job


PR Review: Improve buildernet/mkosi README (re-review after sync)

  • Gather context and read updated changes
  • Review changes and provide feedback

Re-reviewed after the latest push. The changes look good:

  • README.md: Better Quick Start flow (health check before verification), added missing prerequisites (qemu-utils, unzip), new Logs section, clearer "Building Your Own Image" section, inline session-name hint.
  • build.sh: Cleanly absorbs the clone logic from sync.sh, sets up mkosi from .mkosi_version, defaults branch to main (overridable via FLASHBOTS_IMAGES_BRANCH).
  • sync.sh deleted: No stale references remain.

No issues found. The previous review comments about .mkosi_version guards and stale-version checks were acknowledged by the author as out of scope for a reference script — that's reasonable given set -eu provides basic error handling.

@canercidam canercidam merged commit 8ff3442 into main Mar 3, 2026
7 checks passed
@canercidam canercidam deleted the fryd/improve-buildernet-mkosi-readme branch March 3, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants