Skip to content

Run setup commands before image checks#405

Merged
canercidam merged 1 commit intomainfrom
caner/run-setup-before-image-check
Mar 24, 2026
Merged

Run setup commands before image checks#405
canercidam merged 1 commit intomainfrom
caner/run-setup-before-image-check

Conversation

@canercidam
Copy link
Copy Markdown
Member

Fixes #403

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Mar 24, 2026

Claude finished @canercidam's task in 48s —— View job


PR Review

  • Read PR diff and changed files
  • Analyze changes and check for issues
  • Post review

Summary: This PR moves RunSetupCommands to execute before WriteDockerComposeFile and pullNotAvailableImages (which happens inside Run). This allows setup commands (e.g., building custom images) to complete before the image availability check runs, fixing the ordering issue described in #403.

Verdict: Clean, minimal change. No issues found.

The three changes are straightforward:

  1. main.goctx moved earlier (no behavioral change), RunSetupCommands called right after NewLocalRunner and before WriteDockerComposeFile/Run.
  2. local_runner.go — Removes the runSetupCommands call from inside Run().
  3. local_runner_lifecycle.go — Exports runSetupCommandsRunSetupCommands so it's callable from main.go.

No concerns with this change. LGTM.

@canercidam canercidam merged commit 0bf51cc into main Mar 24, 2026
7 checks passed
@canercidam canercidam deleted the caner/run-setup-before-image-check branch March 24, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup commands should run before image validation in generateDockerCompose

1 participant