spammer: record onchain revert as error in db#418
Merged
zeroXbrock merged 3 commits intoflashbots:mainfrom Jan 14, 2026
Merged
Conversation
zeroXbrock
approved these changes
Jan 14, 2026
Member
zeroXbrock
left a comment
zeroXbrock
left a comment
There was a problem hiding this comment.
nice addition, thanks @bitwiseguy! I just made some minor edits; get_tx_error now takes references to receipt & pending_tx to simplify the call and avoid confusion about which fields to pick if the function is used again elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously a tx only had a populated error field if it encountered a send-time errors (e.g. RPC failure, nonce issue, etc.). However, the error field was left as
nullif the tx reverted onchain. Since the code already checks each tx receipt, we can check thereceipt.statusfield to determine if the tx reverted or not.I'm also open to adding a new error field if you want to differentiate between offchain vs onchain error types.