Skip to content

feat/simplify campaign builtin semantics#428

Merged
zeroXbrock merged 2 commits intomainfrom
feat/simplify-campaign-builtin-semantics
Jan 21, 2026
Merged

feat/simplify campaign builtin semantics#428
zeroXbrock merged 2 commits intomainfrom
feat/simplify-campaign-builtin-semantics

Conversation

@zeroXbrock
Copy link
Member

@zeroXbrock zeroXbrock commented Jan 21, 2026

  • remove "builtin:" prefixes from campaign defs
  • remove unused code

Motivation

We don't really need to prefix builtin scenarios with builtin: in campaigns. Ending with .toml is enough to differentiate between builtin & file-based scenarios.

Solution

  • remove prefixes from campaign files
    • I didn't remove the code that strips the builtin: prefix
    • this avoids breaking clients with outdated campaign files, and still works

PR Checklist

  • Added Tests
  • Added Documentation
  • Ran cargo +nightly clippy --workspace --lib --examples --tests --benches --all-features --locked --fix
  • Ran cargo fmt --all
  • Note breaking changes in PR description, if applicable
  • update changelogs
    • Update CHANGELOG.md in each affected crate
    • add a high-level description in the root changelog

@zeroXbrock zeroXbrock merged commit 6821da2 into main Jan 21, 2026
7 checks passed
@zeroXbrock zeroXbrock deleted the feat/simplify-campaign-builtin-semantics branch January 21, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant