Skip to content

Conversation

@Peponks9
Copy link

@Peponks9 Peponks9 commented Nov 24, 2025

enhances observability by including the Git describe output

closes #249

cc @SozinM

Copilot AI review requested due to automatic review settings November 24, 2025 18:34
Copilot finished reviewing on behalf of Peponks9 November 24, 2025 18:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances observability by adding the Git describe output as a label to the builder_info Prometheus metric. The git_describe output provides richer version information than just the Git SHA, including tag information and commit distance.

  • Adds VERGEN_GIT_DESCRIBE constant to expose the git describe output
  • Includes git_describe field in the VersionInfo struct
  • Registers the new label in the builder_info Prometheus metric

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SozinM
Copy link
Collaborator

SozinM commented Nov 27, 2025

Hi!
How's VERGEN_GIT_DESCRIBE different from CARGO_PKG_VERSION + VERGEN_GIT_SHA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: metric reth_builder_info should reflect version

2 participants