Conversation
akundaz
requested review from
0x416e746f6e,
SozinM,
avalonche and
karim-agha
as code owners
julio4
approved these changes
Mar 2, 2026
Member
There was a problem hiding this comment.
I think we could rename the Maybe* traits to just *, like FlashblockFilter/ConditionalTransaction?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Remove the
FBPoolTransactiontrait since it was unused. Use theWith..<Inner>type for filters.Also removed the
MaybeRevertingTransactiontrait since it's not necessary after using this pattern.✅ I have completed the following steps:
make lintmake test