feat: migrate to workspace with rblib-core and rblib-pipeline crates #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
# Conflicts: # crates/core/src/lib.rs # crates/core/src/platform/ethereum/mod.rs # crates/core/src/platform/mod.rs # crates/pipeline/src/orderpool2/prioritized_pool/step.rs # crates/pipeline/src/pipelines/mod.rs # crates/pipeline/src/test_utils/mod.rs # crates/rblib/examples/node-builder.md
Collaborator
|
LGTM, will let Karim approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #103
This PR restructures the codebase into a workspace with dedicated crates:
rblib-core(payload/platform APIs)rblib-pipeline(pipelines/steps/pools)rblibfacadeThe
rblibcrate is only a thin compatibility facade that only reexportsrblib-pipelineto avoid breaking changes for current users to give a window to migrate torblib-pipeline.This allows core primitives to be adopted first, and then gradually migrate to pipeline if needed.
There's still room for improvement, especially by "upstreaming" some feature from pipeline to core after refactoring to remove some coupling (such as test utils).
We could also rename rblib-pipeline to rblib-sdk as an alternative name (maybe less confusing).