Skip to content

Conversation

@dvush
Copy link
Contributor

@dvush dvush commented May 30, 2025

πŸ“ Summary

Adds refund identity

πŸ’‘ Motivation and Context


βœ… I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

Copilot AI review requested due to automatic review settings May 30, 2025 14:08
@dvush dvush requested a review from ZanCorDX as a code owner May 30, 2025 14:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new optional field refund_identity to the Metadata struct, enabling the redistribution mechanism to optionally return a refund identity.

  • Introduces the refund_identity field in Metadata with a default value of None.
  • Updates order redistribution logic to use refund_identity when present.
  • Adjusts synthetic order initialization to include the refund_identity field.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crates/rbuilder/src/primitives/mod.rs Added refund_identity field and initialized it in with_current_received_at().
crates/rbuilder/src/backtest/redistribute/mod.rs Updated order_redistribution_address() to check refund_identity and return it if available.
crates/rbuilder/src/backtest/build_block/synthetic_orders.rs Initialized refund_identity as None in synthetic order metadata.

@dvush dvush merged commit 5366a02 into develop May 30, 2025
2 of 3 checks passed
@dvush dvush deleted the redistrib_new_field branch May 30, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants