Skip to content

Conversation

@dvush
Copy link
Contributor

@dvush dvush commented Dec 2, 2025

πŸ“ Summary

πŸ’‘ Motivation and Context


βœ… I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@dvush dvush marked this pull request as ready for review December 2, 2025 13:45
@dvush dvush requested a review from ZanCorDX as a code owner December 2, 2025 13:45
Copilot AI review requested due to automatic review settings December 2, 2025 13:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the reth dependency from version 1.8.3 to 1.9.3, which involves updating the reth git revision and numerous related dependencies (revm, alloy crates, etc.). The changes include necessary API adaptations to accommodate breaking changes in the new reth version, particularly around provider traits, trie operations, and test utilities.

Key Changes

  • Updated reth from rev 42197415 to 27a8c0f5 (version 1.8.3 β†’ 1.9.3)
  • Updated revm from 29.0.1 to 31.0.2, alloy crates from ~1.0.38 to ~1.0.41
  • Added new trait bounds (TrieReader, StageCheckpointReader, PruneCheckpointReader) to provider types
  • Refactored test infrastructure to use minimum block numbers and updated method names

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Cargo.toml Updated reth git revision and dependency versions for reth, revm, alloy, and related crates
Cargo.lock Lock file updates reflecting all dependency version changes
crates/reth-rbuilder/src/main.rs Added new trait bounds to DatabaseProviderFactory for rbuilder integration
crates/rbuilder/src/utils/provider_factory_reopen.rs Added trait bounds and fixed header method call to dereference parameter
crates/rbuilder/src/roothash/mod.rs Updated to use OverlayStateProviderFactory API and simplified trie input handling
crates/rbuilder/src/provider/*.rs Fixed header method calls to dereference block hash parameters
crates/rbuilder/src/building/precompile_cache.rs Updated to new CallInputs API replacing separate parameters
crates/rbuilder/src/building/testing/*.rs Updated test infrastructure with minimum block numbers and renamed builder methods
crates/rbuilder/src/backtest/build_block/synthetic_orders.rs Updated to use new block number constant

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 4, 2025 11:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.


πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

impl BlockArgs {
pub fn number(self, number: u64) -> Self {
// revm needs to know that merge was activated
pub const MIN_BLOCK_NUMBER: u64 = EthereumHardfork::Prague.mainnet_activation_block().unwrap();
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MIN_BLOCK_NUMBER constant is set to EthereumHardfork::Prague.mainnet_activation_block().unwrap(). Prague is a future hardfork that has not been activated on mainnet yet. Using .unwrap() on a future hardfork activation block will panic if the activation block is not yet defined, which is likely the case. This could cause test failures.

Consider using a hardfork that has already activated on mainnet (like Cancun, Merge, etc.) or handle the case where the activation block is not yet defined.

Suggested change
pub const MIN_BLOCK_NUMBER: u64 = EthereumHardfork::Prague.mainnet_activation_block().unwrap();
pub const MIN_BLOCK_NUMBER: u64 = EthereumHardfork::Cancun.mainnet_activation_block().unwrap();

Copilot uses AI. Check for mistakes.
@ZanCorDX ZanCorDX merged commit 6a9fd27 into develop Dec 4, 2025
10 checks passed
@ZanCorDX ZanCorDX deleted the reth-1.9 branch December 4, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants