Skip to content

metrics updates #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
avalonche merged 4 commits into from
Apr 21, 2025
Merged

metrics updates #178

avalonche merged 4 commits into from
Apr 21, 2025

Conversation

@jowparks
Copy link
Contributor

@jowparks jowparks commented Apr 16, 2025 •
edited
Loading

Adds a few metrics, also updates loopback IP in necessary places.

# TYPE rollup_boost_error counter
rollup_boost_error{code="-38001",span_kind="Client",status="error"} 1

# TYPE rollup_boost_block_building_gas_delta summary
rollup_boost_block_building_gas_delta{payload_source="builder",span_kind="Server",status="unset",quantile="0"} 0
...
rollup_boost_block_building_tx_count_delta_count{payload_source="builder",span_kind="Server",status="unset"} 1

@vercel
Copy link

vercel bot commented Apr 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rollup-boost ⬜️ Ignored (Inspect) Visit Preview Apr 21, 2025 4:20pm

@jowparks jowparks force-pushed the metrics-updates branch 2 times, most recently from ea36bdf to bebc98a Compare April 16, 2025 22:33
@jowparks jowparks marked this pull request as ready for review April 16, 2025 22:34
@avalonche avalonche requested a review from 0xForerunner April 17, 2025 16:57
avalonche
avalonche reviewed Apr 17, 2025
View reviewed changes
avalonche
avalonche reviewed Apr 17, 2025
View reviewed changes
avalonche
avalonche reviewed Apr 17, 2025
View reviewed changes
avalonche
avalonche reviewed Apr 17, 2025
View reviewed changes
avalonche
avalonche reviewed Apr 17, 2025
View reviewed changes
@avalonche avalonche requested a review from 0xOsiris April 17, 2025 17:53
@jowparks jowparks force-pushed the metrics-updates branch 3 times, most recently from 5e61a80 to 8de73df Compare April 17, 2025 18:44
jowparks
jowparks commented Apr 17, 2025
View reviewed changes
@jowparks jowparks requested a review from avalonche April 17, 2025 18:59
avalonche
avalonche reviewed Apr 17, 2025
View reviewed changes
@jowparks jowparks force-pushed the metrics-updates branch 2 times, most recently from 1f2eb7f to 949db70 Compare April 17, 2025 20:55
@jowparks jowparks requested a review from avalonche April 17, 2025 20:58
@jowparks
Update metrics and error handling
616df18 
- Added gas_delta and tx_count_delta to payload metrics in get_payload_v3 and get_payload_v4.
- Updated MetricsSpanProcessor to include INVALID_PAYLOAD tracking.
- Refactored error handling in RpcClient to log invalid payloads instead of incrementing counters directly.
avalonche
avalonche reviewed Apr 17, 2025
View reviewed changes
avalonche
avalonche reviewed Apr 17, 2025
View reviewed changes
@avalonche avalonche merged commit 73e7f02 into flashbots:flashblocks Apr 21, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avalonche avalonche avalonche approved these changes

@0xForerunner 0xForerunner Awaiting requested review from 0xForerunner

@0xOsiris 0xOsiris Awaiting requested review from 0xOsiris

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jowparks @avalonche @cody-wang-cb