Skip to content

Conversation

@SozinM
Copy link
Collaborator

@SozinM SozinM commented Jun 17, 2025

No description provided.

@vercel
Copy link

vercel bot commented Jun 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rollup-boost ⬜️ Ignored (Inspect) Visit Preview Jun 17, 2025 1:13pm

@SozinM SozinM force-pushed the msozin/extract-payload-id-from-FCU-attr branch 2 times, most recently from 8a2bde2 to 8d5ab6c Compare June 17, 2025 12:09
@SozinM SozinM force-pushed the msozin/extract-payload-id-from-FCU-attr branch from 8d5ab6c to fe97b3f Compare June 17, 2025 13:13
@ferranbt ferranbt self-requested a review June 17, 2025 13:44
@SozinM SozinM merged commit 4e3fb84 into main Jun 17, 2025
6 of 7 checks passed
@SozinM SozinM deleted the msozin/extract-payload-id-from-FCU-attr branch June 17, 2025 13:59
@avalonche
Copy link
Collaborator

isn't there an existing function in alloy that calculates this?

@0xOsiris
Copy link
Collaborator

0xOsiris commented Jun 17, 2025

isn't there an existing function in alloy that calculates this?

This was taken from Reth I believe: https://github.com/paradigmxyz/reth/blob/671f0fe566a4906a582027e2781c52b1e2bf3104/crates/optimism/payload/src/payload.rs#L330

This impl could change. imo we should expose this in Reth if we want this logic, and upstream. Also what we are benefiting by including this logic other than incurred latency on FCU's?

@0xKitsune
Copy link
Collaborator

Agreed with @0xOsiris, what is the motivation for this change? Is there a reason that we are calculating the payload id locally here?

@SozinM
Copy link
Collaborator Author

SozinM commented Jun 19, 2025

Hi @0xKitsune @0xOsiris @avalonche sorry for no context :)
We had race condition linked to builder sending first flashblock faster then return FCU answer, this was causing missing flashblocks.
I've copied this function for now, but reth already merging PR to expose this function, so once we update to needed release we will use this function from reth. paradigmxyz/reth#16931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants