dockerfile: default service_name to be 'rollup-boost'#451
Merged
avalonche merged 1 commit intoflashbots:mainfrom Dec 1, 2025
Merged
Conversation
Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Pull request overview
This PR adds a default value to the SERVICE_NAME build argument in the Dockerfile's runtime stage, making it consistent with the builder stage and CI workflows. This improvement allows the Dockerfile to be built without requiring explicit specification of the SERVICE_NAME argument.
Key Changes:
- Sets default value
"rollup-boost"forSERVICE_NAMEARG in the runtime stage (line 66)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
avalonche
approved these changes
Dec 1, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
…up-boost#451) Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 13, 2026
…up-boost#451) Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yashvardhan Kukreja yashvardhan@oplabs.co
We noticed that the newly built rollup-boost image by flashbots doesn't have a binary /usr/local/bin/rollup-boost at its entrypoint.
That's because there's no default value of "rollup-boost" of it (as opposed to the previous docker build stage). Semantically, it would be a pretty sane default to have imo.
This PR achieves that.